search

DataMedSci / pymchelper

Python toolkit for SHIELD-HIT12A and FLUKA
http://datamedsci.github.io/pymchelper/
15 stars 7 forks source link

Fix mistaking highest and lowest energy in plan diagnostics summary #633

Closed nbassler closed 1 year ago

nbassler commented 1 year ago

closes #600

reviewpad[bot] commented 1 year ago

AI-Generated Summary: This pull request contains a single patch that fixes issue #600. The changes are focused on the pymchelper/utils/radiotherapy/plan.py file, where the diagnose function has been updated to correct the printed output for the highest and lowest energies by swapping the lines. In total, 2 lines have been inserted, and 2 lines have been deleted.

reviewpad[bot] commented 1 year ago

Reviewpad Report

:bangbang: Errors

grzanka commented 1 year ago

/rebase

reviewpad[bot] commented 1 year ago

AI-Generated Summary: This pull request consists of 3 patches:

  1. Fixing issue #600 by correcting the print statements for the highest and lowest energy values in the plan.py file. The highest and lowest energy values were swapped in the previous version of the code.
  2. Attempting to fix a versioning problem by updating the .github/workflows/python-app.yml file. A fetch-depth parameter was added to the actions/checkout step to fetch all history, ensuring all necessary commits are fetched.
  3. Further refining the changes from patch 2 by adding comments explaining the purpose of the fetch-depth parameter in the GitHub Actions workflow file.
reviewpad[bot] commented 1 year ago

📈 Pull Request Metrics

💻 Coding Time: 24 seconds 🛻 Pickup Time: 1 day 👀 Review Time: 33 seconds