DataMedSci / pymchelper

Python toolkit for SHIELD-HIT12A and FLUKA
http://datamedsci.github.io/pymchelper/
15 stars 7 forks source link

Add shieldhit executable mock resolves #639 #644

Closed hendzeld closed 1 year ago

reviewpad[bot] commented 1 year ago

AI-Generated Summary: This pull request adds a Python script generate.py and a related bash script shieldhit under the tests/res/shieldhit/mock directory. The generate.py script collects all shieldhit output files in the current directory and generates the bash script named shieldhit. The generated bash script contains all shieldhit output files as base64 encoded strings for later use.

reviewpad[bot] commented 1 year ago

Reviewpad Report

:warning: Warnings

reviewpad[bot] commented 1 year ago

AI-Generated Summary: This pull request contains two patches. The first patch adds a shieldhit executable mock to the tests/res/shieldhit directory, which generates a bash script named shieldhit containing all shieldhit output files as base64 encoded strings. The second patch refactors the generate.py script, replacing usage of the glob and os modules with the more modern pathlib module, and simplifying the script's execution flow by removing a redundant check for the presence of shieldhit files.

grzanka commented 1 year ago

@hendzeld fix conflict

reviewpad[bot] commented 1 year ago

📈 Pull Request Metrics

💻 Coding Time: 52 seconds 🛻 Pickup Time: 13 days 👀 Review Time: 3 days