search

DataMedSci / pymchelper

Python toolkit for SHIELD-HIT12A and FLUKA
http://datamedsci.github.io/pymchelper/
15 stars 7 forks source link

609 planpy issue with coordinate systems #649

Closed nbassler closed 1 year ago

nbassler commented 1 year ago

@grzanka can you take a look?

fix for #609

reviewpad[bot] commented 1 year ago

AI-Generated Summary: This pull request includes two patches:

  1. Adds options to flip x, y or both axes for input data in pymchelper/utils/radiotherapy/plan.py. The options can be used to flip the coordinates, which might be helpful in certain use cases.

  2. Updates tests/test_plan.py to include test cases for the newly introduced flip options. It adds a parameterization for option_name, covering 'flip', 'xflip', and 'yflip' cases.

reviewpad[bot] commented 1 year ago

AI-Generated Summary: This pull request adds options to flip the x and y-axes separately in the radiotherapy plan, modifies the corresponding tests, and refactors the argument parsing to support these new options. The changes involve updating the Plan class and the load, export, and main functions in the plan.py file. New tests are added in test_plan.py to test the flip, xflip, and yflip options, and a test fix is included for non-empty option strings.

reviewpad[bot] commented 1 year ago

📈 Pull Request Metrics

💻 Coding Time: 8 minutes 🛻 Pickup Time: 3 days 👀 Review Time: 12 minutes