fixing calculation of average

DataMedSci / pymchelper

Python toolkit for SHIELD-HIT12A and FLUKA

http://datamedsci.github.io/pymchelper/

14 stars 7 forks source link

Closed grzanka closed 3 months ago

grzanka commented 3 months ago

This PR introduces couple of changes in how multiple runs are averaged:

online version of mean and variance calculation methods are introduced and documented in averaging.py module
error attribute of page is now initialized to None, instead of array of same shape as data - this reduces memory if no error calculation is requested
tests are adjusted accordingly
support for python 3.8 is dropped to fully benefit from type hinting syntax introduced in 3.9

grzanka commented 3 months ago

To test create a virtual environment and run:

pip install git+https://github.com/DataMedSci/pymchelper.git@722-check-if-weighted-average-from-multiple-runs-are-ok#egg=pymchelper

If working on HPC (Ares) remember to include new python ml python first, but do not load official pymchelper package via ml pymchelper.

grzanka commented 3 months ago

TODO:

[x] weights needs to be added to all aggregators update method
[x] weights needs to be seeded (as number of simulated primaries) here https://github.com/DataMedSci/pymchelper/blob/d6c5ac3a5f85b5d74381dac325c83a5a3d584c2d/pymchelper/input_output.py#L120

grzanka commented 3 months ago

@nbassler that should be ready for review now