search

DataONEorg / d1_cn_index_processor

The CN index processor component
0 stars 1 forks source link

Expand elements covered by EML's attribute* index fields beyond just dataTable #2

Closed amoeba closed 3 years ago

amoeba commented 3 years ago

We noticed today that our EML index processing rules in application-context-eml-base.xml only capture attribute elements under a dataTable element (e.g., //dataTable/attributeList/attribute). However, EML supports attributes under all entity types, not just dataTable. This is probably confusing to users and something I think we should address.

I suggest we change the relevant XPath selectors in application-context-eml-base.xml to cover all entity types. I can't think of any downsides to the change, other than having to reindex content. I think all users will want to be able to search for attributes on other entity types.

@datadavev @csjx: Can I get a +1 from you? @mbjones already put in a vote for this change in our salmantics call for this change.

csjx commented 3 years ago

Yes, I think that was just an oversight by Skye, he was not super familiar with all of EML. Sounds good +1.

amoeba commented 3 years ago

Thanks @csjx. I'll take that as enough evidence to move forward with the change. @taojing2002, any chance you have some spare cycles to take a look at this in the next release of this package? Also https://github.com/NCEAS/metacat/issues/1468.

taojing2002 commented 3 years ago

close this issue. See https://github.com/NCEAS/metacat/issues/1361