search

DataONEorg / dataone-web

DataONE static website
Apache License 2.0
2 stars 1 forks source link

Fix broken links in navigation #162

Closed laurenwalker closed 2 years ago

laurenwalker commented 2 years ago

@robyngit I wanted to get your second opinion on this. I put hard-coded URLs to the DataONE Search pages in the navigation YAML but I see that we have a SEARCH keyword that is replaced with the DataONE Search base URL in other parts of the navigation. But when I tried using the SEARCH variable it didn't seem to work. I think it only works in the user menu.

If that's the case, go ahead and approve this PR and we'll use the hard-coded URLs. But if there is a better way, feel free to comment here and I'll change the PR. Thanks.

Fixes #161

aebudden commented 2 years ago

@robyngit @laurenwalker Is this PR OK be be merged? I just made some changes to the community call on preview and would like to get them published

robyngit commented 2 years ago

@aebudden, yes this PR is okay to merge