search

DataONEorg / dataone-web

DataONE static website
Apache License 2.0
2 stars 1 forks source link

Fix file name issues with new webinar content #81

Closed robyngit closed 4 years ago

robyngit commented 4 years ago

Great to see the webinar pages filling out with content, @erinlynmclean! 🎉 I noticed two minor issues related to file names and I want to make sure that they aren't missed:

1. The files that contain speaker information were re-named after linking them to the to webinars

The result is that the speakers are not showing up on the webinar pages anymore. For example, the speaker is set to people/file-2.md in the webinar Collaboration Across Time and Space in the LTER Network. I guess that file-2.md was re-named to marty-downs.md, but this file name also needs to be updated in the webinars where Marty is the speaker. Perhaps we can come up with a better way to link webinar content to speaker content, but I guess this won't be a big issue after all the content is transferred over.

2. File names for webinars are mis-matched to webinar titles

For example, the webinar named "Collaboration Across Time and Space in the LTER Network" has the filename academic-data-science-from-individuals-to-institutions.md.

With the way the site is currently configured, this means that navigating to the URL https://preview.dataone.org/webinars/academic-data-science-from-individuals-to-institutions/ will lead to the "LTER Network" webinar. I can change the site config so that webinar URLs are generated from the webinar title or another variable, but I think that the file names should be corrected in any case, since this mis-match will be confusing to anyone editing content manually.

Ideally, we should make the file names exactly match the slug for the corresponding webinar page on the old website. That way anyone navigating to the old webinar URLs will be directed to the same webinar in the new website. In the case of the "LTER Network" webinar then, the file name should be collaboration-across-time-and-space-lter-network.md to match the URL "https://www.dataone.org/webinars/collaboration-across-time-and-space-lter-network".

The content audit page might be helpful here

aebudden commented 4 years ago

In the case of file names that may have been a copy and paste error? LTER collaboration and Academic data science are two different webinars vs two different titles for the same webinar. Agreed that they should match the old DataONE page. Thx

robyngit commented 4 years ago

Erin and I are discussing it and it seems like it could be a strange bug in Forestry, since all of this content was created within it. Normally forestry makes file names based on the titles of pages, but in this case, every webinar seems to have a file name that matches some other webinar. I'm wondering if we should create a "slug" field so that we can explicitly set the end part of the URL.

robyngit commented 4 years ago

I did some double-checking and it looks like this is fixed. All the webinar speaker references have a matching person file. Also, all the slug fields match the slugs for the old webinar pages, however... In checking this, I discovered that there is an issue with how hugo encodes URLs, see https://github.com/DataONEorg/dataone-web/issues/84