search

DataONEorg / object-formats

DataONE Object Formats controlled vocabulary
Apache License 2.0
1 stars 3 forks source link

Document how to submit edits to existing formats #7

Closed twhiteaker closed 3 years ago

twhiteaker commented 3 years ago

You may want a separate template for this, similar to the "submit a new format" template. You may also want a branch naming pattern similar to how feature_#_format is used for new formats. I think the existing branch naming pattern would also work for format edits, so maybe just think about whether the template is also good for both purposes (new vs edit).

mbjones commented 3 years ago

I think a simpler template could work, as the formatId can not be changed. Other metadata can be changed, but presumably shouldn't fundamentally alter the type definition. If a typo or other change in metadata is needed, that would be fine, and all we really need to know is what the new value is, and why it should be changed.

mbjones commented 3 years ago

I added a new template for a proposed set of changes to an existing format. Let me know how that looks @twhiteaker

Regarding branch naming patterns, I think we can just use feature_#_format for this as well.

twhiteaker commented 3 years ago

Looks good. Just remove the extra space between mediaType and the colon.