search

DataONEorg / rdataone

R package for reading and writing data at DataONE data repositories
http://doi.org/10.5063/F1M61H5X
36 stars 19 forks source link

Review getDataObject() operation #227

Closed gothub closed 6 years ago

gothub commented 6 years ago

The getDataObject() method retrieves an object given a D1Client instance and a pid, but uses the CN resolve service to determine which member node to get the object from. It would be more efficient to get all objects from the member node contained in the passed in D1Client instance.

This would also have the effect of having getDataPackage get all objects from the same MN, which would probably be faster than calling CN resolve for each object.

gothub commented 6 years ago

Discussed this with @mbjones and verified that we will keep the current method, as it leverages the strength of DataONE (CN resolve() providing currently accessible MNs/objects).