DataONEorg / rdataone

R package for reading and writing data at DataONE data repositories
http://doi.org/10.5063/F1M61H5X
36 stars 19 forks source link

Release 2.2.1 #247

Closed gothub closed 3 years ago

gothub commented 4 years ago
gothub commented 3 years ago

@mbjones the most recent code on the develop branch has been tested with:

without any ERRORs or WARNINGS.

Submitting to check_win_devel() is the best practices method for checking for URLs that cause redirects, according to Jim Hester (https://github.com/r-lib/devtools/issues/2276), and rdataone has passed that check.

Should I merge develop to master and resubmit? There are no warnings regarding redirected URLS. I don't see a way to

mbjones commented 3 years ago

Yes, that sounds good for now. It seems like the suggestion to run devtools::check(remote = TRUE, cran=TRUE) is the best way once the version of R that checks incoming checks is out there (which I think is already in r-devel for R 4.1). So I think this will be a good approach to be able to test this stuff locally before having to submit to remote services once R 4.1 is out. So, please add the remote=TRUE flag to your checklist.

mbjones commented 3 years ago

All done.