search

DataONEorg / rdataone

R package for reading and writing data at DataONE data repositories
http://doi.org/10.5063/F1M61H5X
36 stars 19 forks source link

if public = TRUE, set public access on data objects AND indicate sysm… #289

Closed jeanetteclark closed 2 years ago

jeanetteclark commented 2 years ago

…eta is updated for those objects

this ensures that updateDataObject picks up on the change down the line. addresses issue #285

I've done some testing locally but haven't written a formal test yet

gothub commented 2 years ago

@jeanetteclark the change made in this commit look just fine.

The only trouble is that your branch was made from the main branch and not develop, which is currently 10 commits ahead of main, and has changes to D1Client.R. I'm not sure if we can just change the target branch to develop in the PR/Review/Merge, or if something else needs to happen.

jeanetteclark commented 2 years ago

Hm okay. I guess I thought that the dev.release branches replaced develop, but that is not the case? I can change my branch and get the commit in the right place no problem though

gothub commented 2 years ago

This diagram which explains the relationship between the branches should be in every NCEAS/DataONE repository. Please have a look and post here if the branches don't look correct.

https://github.com/NCEAS/metacatui/blob/main/CONTRIBUTING.md