DataONEorg / sem-prov-ontologies

Ontologies focused on scientific observations and scientific workflow provenance.
https://ontologies.dataone.org
17 stars 7 forks source link

fix GHA automated builds #127

Open mbjones opened 1 month ago

mbjones commented 1 month ago

The Github Actions continuous integration builds a broken and not running due to:

Fix these and get the website building again.

mbjones commented 1 month ago

As of sha 7622d47b the GHA build is working again for the ci.yaml workflow, and so the website is now building. The MOSAIC validation script is still failing, but it seems to be a problem with the verification of terms against Pangaea. Needs some digging.

mbjones commented 3 days ago

I looked into the error from the MOSAiC checks, and the problem is indeed that the Pangaea web service is now producing a list of campaigns that includes identifiers that are not found in the ontology. Here'e the type of error returned:

| Exception: Campaign with label 'SO275' not found in the expected set ['PS122/5', 'PS122/4', 'P5_223_MOSAiC_ACA_2020', 'P5-223_MOSAiC_ACA_2020', 'PS122/1', 'PS122/2', 'PS122/3', 'AF-MOSAiC-1', 'P6_222_IceBird_MOSAiC_2020', 'P6-222_IceBird_MOSAiC_2020', 'AT-MOSAiC-1']

The list of identifiers from the ontology and pangaea site, and whether they match, are:

Ontology Pangaea Match?
PS122/5 PS122/5 yes
PS122/4 PS122/4 yes
PS122/1 PS122/1 yes
PS122/2 PS122/2 yes
PS122/3 PS122/3 yes
AF-MOSAiC-1 AF-MOSAiC-1 yes
AT-MOSAiC-1 AT-MOSAiC-1 yes
P5_223_MOSAiC_ACA_2020 P5-223_MOSAiC_ACA_2020 no
P6_222_IceBird_MOSAiC_2020 P6-222_IceBird_MOSAiC_2020 no
SO275 no
MSM92 no
KD-MOSAiC-1 no

For P5_223_MOSAiC_ACA_2020 and P6_222_IceBird_MOSAiC_2020, the only difference seems to be the _ character was changed to -, so a new rdfs:label can be added to those existing campaigns. For SO275, MSM92, and KD-MOSAiC-1, the campaigns need to be added to the ontology file.