DataONEorg / sem-prov-ontologies

Ontologies focused on scientific observations and scientific workflow provenance.
https://ontologies.dataone.org
18 stars 7 forks source link

ARCRC new ontology terms + formatting + metadata, SALMON new run size term + formatting + metadata #134

Closed justinkadi closed 2 months ago

justinkadi commented 3 months ago

ARCRC turtle file

SALMON turtle file

justinkadi commented 3 months ago

@mbjones it looks like there were some checks that failed. Are these things that I should be able to fix?

mbjones commented 3 months ago

@justinkadi the validate check is something you can fix -- there's a syntax problem of some sort on the indicated line of the ontology file. Should be pretty easy to track down. We don't want to do a release until the CI/validate check works. The other failing test is the Mosiac check, which hasn't worked in a long time (I traced it down to a change in the MOSAiC service, so its not your ontology changes causing it, and you can ignore it for now (you aren't even working on the MOSAiC ontology).

justinkadi commented 2 months ago

@mbjones I was able to fix the CI/validate check. I noticed the CI/website was skipped, but I think it's ready for merging otherwise.