Closed stevenchong closed 5 years ago
Thanks @stevenchong . Looks good. Do you need me to review anything specifically?
Not specifically. It was more to make you aware that you'll have to update version in ADC production after merging. I'll let you push the button when you're ready.
Gotcha. My feeling from #41 was that we'd follow a little more formal process for ontology updates so I'll coordinate with @mpsaloha and @mobb on planning and cutting a 0.10 release which this'd go into.
This PR has new terms that were added to annotate the more recent ADC carbon measurements (~after 6/2019). It's related to: https://github.nceas.ucsb.edu/KNB/arctic-data/issues/320#issuecomment-25265
After this PR gets merged, the version of ECSO8 in Github (in the ECSO8-add_non_carbon_measurements branch) will be ahead of the ECSO version used to index the semantic annotations in ADC production -- (i.e. the ADC production ECSO file will need to be manually synced with the version in Github).