search

DataONEorg / slinky

Slinky, the DataONE Graph Store
Apache License 2.0
4 stars 4 forks source link

Fix failing tests on develop from PR #69 merge #72

Closed amoeba closed 2 years ago

amoeba commented 2 years ago

PR https://github.com/DataONEorg/slinky/pull/69 introduced four failing tests,

FAILED tests/test_eml201_processor.py::test_processor_extracts_top_metadata - httpx.ConnectError: [Errno 61] Connection refused
FAILED tests/test_eml210_processor.py::test_processor_extracts_top_metadata - httpx.ConnectError: [Errno 61] Connection refused
FAILED tests/test_eml211_processor.py::test_processor_extracts_top_metadata - httpx.ConnectError: [Errno 61] Connection refused
FAILED tests/test_eml_processor.py::test_processor_extracts_top_metadata - httpx.ConnectError: [Errno 61] Connection refused

I'm not sure what's going on here but I'll take a look. These types of tests shouldn't require a network connection so something is probably wrong in test setup.

amoeba commented 2 years ago

Fixed unit tests in https://github.com/DataONEorg/slinky/commit/69dab0b1243b9237635b9748598654d598af7aa8 and ended up tweaking how environment variables work so we just use one env var per service (not two). See https://github.com/DataONEorg/slinky/commit/69dab0b1243b9237635b9748598654d598af7aa8 @ThomasThelen.