DataONEorg / slinky

Slinky, the DataONE Graph Store
Apache License 2.0
4 stars 4 forks source link

Address SOSO SHACL Feedback & Cleanup #78

Open ThomasThelen opened 1 year ago

ThomasThelen commented 1 year ago

A few updates to Slinky for the 0.3.0 release

Slinky Dockerfile

Virtuoso

We had two copies of our custom Virtuoso Dockerfile. I removed the redundant one in the test directory

dump-virtuoso

This script requires you to have the _dumpnquads function defined within Virtuoso (which default deployments no longer do). I added this function and another bit to copy the data files out of the container.

Web

Addresses a few points in https://github.com/DataONEorg/slinky/issues/73. Since the page depends on yasgui and the css, I left them as blocking resources.

Triple Pattern Changes

I ran the SOSO 1.2.3 SHACL file against the triples we're producing in develop with

pyshacl -s ~/science-on-schema.org/validation/shapegraphs/soso_common_v1.2.3.ttl -m -i rdfs -f human data.nq

These are the results. This PR currently fixes the keywords violation and sameAs warning.

there was a second violation with schema:version - but I filed an issue for that one.

Google Recommended

We fail a few of the recommended google shapes (we pass the required one though).

SHACL Result
googleReccomended result
googleReccomendedCoverageCheck result

For 0.3.0 these might not be worth addressing and could go in a 0.3.1.