search

DataObjects-NET / dataobjects-net

https://dataobjects.net
MIT License
60 stars 23 forks source link

Upgrade to SqlClient 5.1.0 with DateOnly/TimeOnly support #304

Closed SergeiPavlov closed 1 year ago

SergeiPavlov commented 1 year ago

SqlClient 5.1.0 has support of DateOnly/TimeOnly types No need for intermediate conversion

alex-kulakov commented 1 year ago

If you update a storage-specific thing, don't change base implementation, change and override in the the provider, changing the base one can break and probably will break other providers.

alex-kulakov commented 1 year ago

I'm going to publish an RC version of 7.1 with DateOnly/TimeOnly support across all supported types of storages (PR #307). This PR fits it too. But with exception of these two no merges will happen before RC.

SergeiPavlov commented 1 year ago

If you update a storage-specific thing, don't change base implementation, change and override in the the provider, changing the base one can break and probably will break other providers.

Fixed

alex-kulakov commented 1 year ago

Also, for the future, TypeMapper has clear structure of grouped methods, It would be appreciated if ReadXxx, BindXxx and MapXxx methods were added in their groups. It would smooth review process and give you extra points of karma 😉