Refactors the algorithmic implementation of ShaRP. The API interface of the library is entirely different.
Before submitting
- Was this **discussed/agreed** via a GitHub issue? (not for typos and docs)
- [x] Did you read the [contributor guideline](https://github.com/joaopfonseca/sharp/blob/main/CONTRIBUTING.md), **Pull Request** section?
- [x] Did you make sure your **PR does only one thing**, instead of bundling different changes together?
- Did you make sure to **update the documentation** with your changes? (if necessary)
- Did you write any **new necessary tests**? (not for typos and docs)
- [ ] Did you verify new and **existing tests pass** locally with your changes?
- Did you list all the **breaking changes** introduced by this pull request?
PR review
Anyone in the community is welcome to review the PR. Before you start
reviewing, make sure you go through the following bullet-list:
Reviewer checklist
- [ ] Is this pull request ready for review? (if not, please submit in draft mode)
- [ ] Check that all items from **Before submitting** are resolved
- [ ] Make sure the title is self-explanatory and the description concisely explains the PR
- [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified
What does this PR do?
Refactors the algorithmic implementation of ShaRP. The API interface of the library is entirely different.
Before submitting
- Was this **discussed/agreed** via a GitHub issue? (not for typos and docs) - [x] Did you read the [contributor guideline](https://github.com/joaopfonseca/sharp/blob/main/CONTRIBUTING.md), **Pull Request** section? - [x] Did you make sure your **PR does only one thing**, instead of bundling different changes together? - Did you make sure to **update the documentation** with your changes? (if necessary) - Did you write any **new necessary tests**? (not for typos and docs) - [ ] Did you verify new and **existing tests pass** locally with your changes? - Did you list all the **breaking changes** introduced by this pull request?PR review
Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you go through the following bullet-list:
Reviewer checklist
- [ ] Is this pull request ready for review? (if not, please submit in draft mode) - [ ] Check that all items from **Before submitting** are resolved - [ ] Make sure the title is self-explanatory and the description concisely explains the PR - [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified