DataSeer / dataseer-web

DataSeer web application
GNU General Public License v3.0
13 stars 1 forks source link

Pathway for new and changing Datatypes in the Wiki #385

Open Souad314 opened 3 years ago

Souad314 commented 3 years ago

What happens to uploaded files in DataSeer when a datatype is deleted from the wiki? For example, we recently reclassified Code and Protocol to Other: Code and Other: Protocol, and added Other: Reagent image But now all the ASAP files that had those previous datatypes have confused the program: https://www.loom.com/share/27d685fdf50143c3aa09cfef2e48b560 When you change the first misclassified datatype, the next ones will follow until (I'm assuming) there's another datatype? then it reverts to the previous datatype. It's been somewhat of a hassle to go back and reclassify them individually, but if the volume of articles increases it may become unmanageable. What if something were to happen to the whole wiki? Also, what about files in different stages of processing? For example, if a document is in its Finished Process, will all instances of code still be deleted because the internal links are broken?

NicolasKieffer commented 3 years ago

When you change the first misclassified datatype, the next ones will follow until (I'm assuming) there's another datatype? then it reverts to the previous datatype. What happens to uploaded files in DataSeer when a datatype is deleted from the wiki? Also, what about files in different stages of processing? For example, if a document is in its Finished Process, will all instances of code still be deleted because the internal links are broken?

The datatype is not deleted, it is still stored in the database (You can see it on the "finish" page) It appear as "None" on the "datasets" step only because "the interface" do not find it in the list. (because this case is not handled for the moment. I will fix it).

It's been somewhat of a hassle to go back and reclassify them individually, but if the volume of articles increases it may become unmanageable.

I could not implement a simple "graphical solution" to fix this case. I can update datatypes directly in the database if necessary. (working directly on the database to correct this type of change is the fastest)

What if something were to happen to the whole wiki?

All datasets keep their datatype, but you won't be able to saw it on the "datasets" step anymore (until I fix this bug).

NicolasKieffer commented 3 years ago

(available on dev & production server) Now, if the datatype is not in the list, it wil be displayed in the field "custom datatype". image