DataShades / ckanext-saml2

SAML2 Authentication extension for CKAN
5 stars 23 forks source link

OEHXCDCD-362 / change c.user name to real user name, not user id #34

Closed smotornyuk closed 8 years ago

MrkGrgsn commented 8 years ago

A couple of minor points.

I think it would be slightly better style if it doesn't set c.userat line 250 and only sets it after setting c.userobj as in your 2nd commit.

It would also be more intuitive to refer to the value pulled from REMOTE_USER as name_id instead of user.