Closed michaelweylandt closed 5 years ago
As discussed at [1], uint is not standard C++. We should use arma::uword consistently instead.
uint
arma::uword
There's also a signed/unsigned comparison at [2] that should be fixed. I think switching to arma::uvec should suffice.
arma::uvec
[1] https://stackoverflow.com/q/3552094 [2] https://github.com/DataSlingers/ExclusiveLasso/blob/5a75b7cbe82018bf414e3d12ed2f1e39f36228e1/src/ExclusiveLasso.cpp#L50
Closed by #12
michaelweylandt
commented
5 years ago michaelweylandt
commented
5 years ago
As discussed at [1],
uintis not standard C++. We should usearma::uwordconsistently instead.There's also a signed/unsigned comparison at [2] that should be fixed. I think switching to
arma::uvecshould suffice.[1] https://stackoverflow.com/q/3552094 [2] https://github.com/DataSlingers/ExclusiveLasso/blob/5a75b7cbe82018bf414e3d12ed2f1e39f36228e1/src/ExclusiveLasso.cpp#L50