search

DataSlingers / MoMA

MoMA: Modern Multivariate Analysis in R
https://DataSlingers.github.io/MoMA
GNU General Public License v2.0
22 stars 4 forks source link

Add nested BIC #25

Closed Banana1530 closed 5 years ago

Banana1530 commented 5 years ago

The .so file is compiled from the C code provided here. https://statweb.stanford.edu/~candes/SortedL1/

michaelweylandt commented 5 years ago

Re: .so file -- are we using it for testing? I don't see what it's being used for and, if so, wouldn't we want the original C code so we can do cross-platform testing?

michaelweylandt commented 5 years ago

I can't tell why this is failing, but it looks like one of the dependencies is now trying to pull in a BioConductor dependency, possibly by way of igraph. (I don't know why we would need igraph for our small set of dependencies - maybe one of the Suggests packages?)

Regardless, this PR has gotten a bit enormous - is it possible to break it out into smaller chunks? That might help us narrow down which new feature is causing the problem.

Banana1530 commented 5 years ago

I will take care of it in the next few days before the coding period starts.

michaelweylandt commented 5 years ago

Merged!

Great work @Banana1530 - I know this took a long time to get right, but it's super important for future usability