DataSlingers / MoMA

MoMA: Modern Multivariate Analysis in R

https://DataSlingers.github.io/MoMA

GNU General Public License v2.0

22 stars 4 forks source link

Closed Banana1530 closed 5 years ago

Banana1530 commented 5 years ago

Deploying code format checking on CI would take some time, let's deal with it later.

22

michaelweylandt commented 5 years ago

How hard would it be to do format checking on Travis?

If we merge this PR without an automatic check on later PRs, I'd worry we'd get into a repeating cycle of huge PRs and messy commit histories.

Banana1530 commented 5 years ago

Ok I will fix it soon. Locally on my PC I set up a hook that auto-formats the code whenever I save it so I thought maybe we can skip it first.

michaelweylandt commented 5 years ago

We don't need it to re-format in Travis, just to do a check that it's well formatted. (I'm happy to tell the dev to re-format.)

Banana1530 commented 5 years ago

This PR is replaced by #33