Design improve - Githubissues

DataSlingers / MoMA

MoMA: Modern Multivariate Analysis in R

https://DataSlingers.github.io/MoMA

GNU General Public License v2.0

22 stars 4 forks source link

Closed Banana1530 closed 5 years ago

Banana1530 commented 5 years ago

Two main focuses in this PR:

Add three member functions for the class MoMA.
A comprehensive test suite for cpp_multirank_BIC_grid_search, which will be the core of multivariate methods.

michaelweylandt commented 5 years ago

Anything else you think we should do for this PR or is it good to merge?

Banana1530 commented 5 years ago

Let's merge this PR. But one thing of concern is how to deal with deflation for CCA in current design.