Banana1530 commented 5 years ago

https://drive.google.com/drive/folders/1zMhMaKsgrTYObsmQ6D8u3CGvLxN7I3ZQ?usp=sharing

Here are screen shots of the shiny interface.

3ffe8af currently fails on Mac but passes on Linux. Will look into it soon.

michaelweylandt commented 5 years ago

This can now be rebased (not merged) against the current master.

codecov[bot] commented 5 years ago

Codecov Report

Merging #47 into master will decrease coverage by 6.61%. The diff coverage is 64.97%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   90.17%   83.56%   -6.62%     
==========================================
  Files          32       34       +2     
  Lines        2372     3042     +670     
==========================================
+ Hits         2139     2542     +403     
- Misses        233      500     +267

Impacted Files	Coverage Δ
src/moma_base.h	`100% <ø> (ø)`	:arrow_up:
src/moma_solver.h	`100% <ø> (ø)`	:arrow_up:
R/moma_expose.R	`91.13% <ø> (-0.53%)`	:arrow_down:
src/moma.h	`100% <ø> (ø)`	:arrow_up:
src/moma_solver_BICsearch.cpp	`100% <100%> (ø)`	:arrow_up:
src/moma_solver.cpp	`94.89% <100%> (+0.15%)`	:arrow_up:
R/moma_sfpca.R	`63.93% <35.79%> (-26.71%)`	:arrow_down:
R/moma_sfcca.R	`75.53% <75.53%> (ø)`
R/moma_sflda.R	`76.11% <76.11%> (ø)`
R/moma_arguments.R	`88.97% <82.05%> (-1.77%)`	:arrow_down:
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00839b5...50199f8. Read the comment docs.

michaelweylandt commented 5 years ago

This might be useful: https://www.rstudio.com/resources/webinars/testing-shiny-applications-with-shinytest/

Banana1530 commented 5 years ago

I read about shinytest when I was browsing through your Rclustviz repo. It's a bit difficult to compare the plots due to platform reasons, but we can test the sliders work as expected.

c30d3ae passed on Mac but failed on Linux due to "PhantomJS not found".

Banana1530 commented 5 years ago

See branch https://github.com/Banana1530/MoMA/commits/shiny

DataSlingers / MoMA

A Shiny app for PCA #47

Codecov Report