DataSlingers / MoMA

MoMA: Modern Multivariate Analysis in R
https://DataSlingers.github.io/MoMA
GNU General Public License v2.0
22 stars 4 forks source link

Put parameters values in sparsity / smoothness specification #48

Closed Banana1530 closed 5 years ago

Banana1530 commented 5 years ago

43

michaelweylandt commented 5 years ago

Hey - I added a few comments, but not sure they all came through since I was putting them on individual commits instead of the PR as a whole.

If you can rebase this to work on top of #42, I can review just the diff between the two PRs. (Once #42 is merged, you can then change the merge target of this PR directly into the main repo.)

codecov[bot] commented 5 years ago

Codecov Report

Merging #48 into master will increase coverage by 0.18%. The diff coverage is 96.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   89.98%   90.17%   +0.18%     
==========================================
  Files          32       32              
  Lines        2487     2372     -115     
==========================================
- Hits         2238     2139      -99     
+ Misses        249      233      -16
Impacted Files Coverage Δ
R/moma_expose.R 91.66% <ø> (-1.34%) :arrow_down:
R/moma_sfpca.R 90.64% <100%> (+1.89%) :arrow_up:
R/moma_arguments.R 90.74% <87.5%> (-1.4%) :arrow_down:
R/util.R 95.45% <95.23%> (-4.55%) :arrow_down:
src/moma_heap.cpp 68.23% <0%> (-2.1%) :arrow_down:
src/moma_fivedlist.cpp 80% <0%> (-1.82%) :arrow_down:
src/moma_prox.cpp 89.85% <0%> (-0.69%) :arrow_down:
src/moma.cpp 84.26% <0%> (-0.52%) :arrow_down:
src/moma_prox_l1ft.cpp 92.62% <0%> (-0.24%) :arrow_down:
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14c8ca9...031082b. Read the comment docs.

michaelweylandt commented 5 years ago

This can now be rebased against the current master. Once that's done, I'll make another review pass over the diff.