Open Banana1530 opened 5 years ago
Still not wild about the b / g coding. I think it's a bit tricky for users to discover.
b
g
Thinking ahead, we definitely want BIC selection, but might also want AIC and eBIC. Maybe
select = FALSE as the default (corresponding to keeping a full grid) and allow select = c("BIC", "AIC", "EBIC") as alternative values.
select = FALSE
select = c("BIC", "AIC", "EBIC")
Originally posted by @michaelweylandt in https://github.com/michaelweylandt/MoMA/pull/48/files
Still not wild about the
b/gcoding. I think it's a bit tricky for users to discover.Thinking ahead, we definitely want BIC selection, but might also want AIC and eBIC. Maybe
select = FALSEas the default (corresponding to keeping a full grid) and allowselect = c("BIC", "AIC", "EBIC")as alternative values.Originally posted by @michaelweylandt in https://github.com/michaelweylandt/MoMA/pull/48/files