search

DataSlingers / MoMA

MoMA: Modern Multivariate Analysis in R
https://DataSlingers.github.io/MoMA
GNU General Public License v2.0
22 stars 4 forks source link

NEW Deflation for CCA and LDA #54

Closed Banana1530 closed 5 years ago

Banana1530 commented 5 years ago

PR #46 is moved here.

Banana1530 commented 5 years ago

Merge into develop under the new branch scheme instead of master -DONE

Increase coverage of the new stuff - this is a big hit compared to the previous version -NOT YET

Pull the Shiny stuff out of this PR and just leave it as CCA and LDA - DONE. Pulled out.

Clean up the history - DONE.

michaelweylandt commented 5 years ago

Is this PR supposed to add pkgdown websiting as well? If so, I think we'll need an adjustment in build_steps.R

michaelweylandt commented 5 years ago

I hadn't given Travis permission to read this under the DataSlingers organization, but I just did. Hopefully the next commit in this branch will kick off a build properly.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@784871b). Click here to learn what that means. The diff coverage is 76.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #54   +/-   ##
==========================================
  Coverage           ?   85.63%           
==========================================
  Files              ?       34           
  Lines              ?     3182           
  Branches           ?        0           
==========================================
  Hits               ?     2725           
  Misses             ?      457           
  Partials           ?        0
Impacted Files Coverage Δ
src/moma.h 100% <ø> (ø)
R/moma_solve.R 98.07% <ø> (ø)
src/moma_solver.h 100% <ø> (ø)
src/moma_base.h 100% <ø> (ø)
src/moma_solver_BICsearch.cpp 100% <100%> (ø)
R/moma_arguments.R 94.33% <100%> (ø)
src/moma_solver.cpp 94.73% <100%> (ø)
R/moma_sflda.R 59.8% <59.8%> (ø)
R/moma_sfcca.R 74.64% <74.64%> (ø)
R/moma_expose.R 91.66% <83.33%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 784871b...03923ee. Read the comment docs.

Banana1530 commented 5 years ago

What changes are needed in the build_step.R?

michaelweylandt commented 5 years ago

Re: build_steps.R I think we need something to actually build the pkgdown site.

michaelweylandt commented 5 years ago

Merging now to get this in before GSoC ends.