Closed michaelweylandt closed 4 years ago
Hi!
Thank you for your Pull Request!
It looks like you have set the target branch of your PR to master.
In this repo, the master
branch is used for stable versions only and
development is done on the develop
branch.
In order to help us most efficiently review and merge your PR, would you
please change the base branch to develop
? This will activate our
continuous integration testing and make it easier to merge your PR.
Instructions for changing the base branch can be found at https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-base-branch-of-a-pull-request
Thanks!
As per test above, auto-commenting seems to work! Now re-targeting to develop
to test CI on R 4.0.
@kenzeng24 and @jasminezhuoy
I'm trying to improve the CI process for this repo to help make things easier for potential contributors.
Would a message like the one from the bot earlier in this thread have been welcoming and clearly explain how and why to change the base/target branch of a PR to develop
?
Thanks!
The CI failure on Ubuntu is a segfault which appears to come from something in the gif rendering stack. I think it's harmless to ignore - it's certainly orthogonal to this PR.
Closes #99 and #102
develop
rather thanmaster