search

DataTables / DataTablesSrc

DataTables source repository
https://datatables.net
MIT License
634 stars 425 forks source link

Checkbox not in the center of the row #164

Closed gerryge closed 4 years ago

gerryge commented 4 years ago

I am using the style of bootstrap 4. I am not sure why set the checkbox margin-top: -6px in select.bootstrap4.css file.

Please see the screenshot: select bootstrap4

BTW, in datatables.net-select-bs4 package, there are js files which one is "select.bootstrap4.js". I want to know what this js does, because I found description of installation select extension and datatables.net-select-bs4 is styling via css only. Whether this is not need to include the select.bootstrap4.js in my project? image

https://datatables.net/download/npm

npm install datatables.net-select
npm install datatables.net-select-bs4 // Styling via CSS only
DataTables commented 4 years ago

Yup - some prefer it to be at the top of the box, so it is consistent on multi-line rows. Something not quite right there still though. Could you link to a test case showing the issue please.

Also, in future, please could you post support requests in the forums? Thanks (it just means there is a central, searchable, corpus of knowledge for them).

gerryge commented 4 years ago

Yes, thank you very much.

Do you want this? http://live.datatables.net/vuzekemo/6/edit

I still want to know select.bootstrap4.js file does? Whether I need it?

DataTables commented 4 years ago

Thanks! Fixed here: https://github.com/DataTables/Select/commit/49e583841acab83c8e388381a09b1d5a50670491

gerryge commented 4 years ago

Thanks.👍