search

DataTables / DataTablesSrc

DataTables source repository
https://datatables.net
MIT License
628 stars 423 forks source link

types: Fix column definitions and oSort #231

Closed apeschar closed 1 year ago

apeschar commented 1 year ago

Two fixes for the TypeScript definitions:

  1. Require either targets or target on a column definition. The current types don't work because they require target to be specified, even when targets are given.
  2. Add oSort on the definitions for ext.
AllanJard commented 1 year ago

I like it - thanks for the PR. Are you happy for this to be merged under the MIT license?

apeschar commented 1 year ago

I like it - thanks for the PR.

Glad to hear. :)

Are you happy for this to be merged under the MIT license?

Yes.

AllanJard commented 1 year ago

Nice one - thank you :)