DataTables / DataTablesSrc

DataTables source repository
https://datatables.net
MIT License
587 stars 422 forks source link

GitHub and NPM's variants of 1.13.8's dist files still show 1.13.7 as their version number (with 1.13.8's changes) #251

Closed EricDunsworth closed 4 months ago

EricDunsworth commented 7 months ago

Hi,

This probably isn't much of an issue in practice, but I figured it might still be worth reporting.

The variant of 1.13.8 that was released on GitHub (DataTables/Dist-DataTables) and NPM still shows 1.13.7 in its JS files. But only the version number is outdated - all of 1.13.8's other changes are in place. By comparison, the CDN's variant of 1.13.8 shows the correct version.

Apart from being inconsistent with the CDN, the version number difference also causes GitHub and NPM's variants of 1.13.8 to falsely report DataTable.version as 1.13.7.

Links:

Thanks :)!

AllanJard commented 4 months ago

Should be sorted out with the 1.13.10 release (1.13.9 didn't hit npm due to an error in another package manager that meant I had to release 1.13.9 and 1.13.10).

EricDunsworth commented 4 months ago

@AllanJard Should a 1.13.10 tag be added to the GitHub repo too? Looks like it's only up on the CDN and NPM atm. GitHub's latest tag is currently 1.13.9.

Although it looks like 1.13.8-10 are effectively all the same - aside from version numbers.

Thanks :)!

AllanJard commented 4 months ago

Darn it - I thought I'd done that. Yes there should be. I'll sort that out :).

There is a small change in the CSS and two other tweaks, but basically its the same.

EricDunsworth commented 4 months ago

@AllanJard Oh whoops - guess my eyes were too glued to the JS files :P heh.

Thanks again :)!