Fix upload with upload_tmp_dir outside open_basedir

DataTables / Editor-PHP

PHP server-side libraries for Editor

Other

35 stars 22 forks source link

Fix upload with upload_tmp_dir outside open_basedir #9

Closed mvorisek closed 2 years ago

AllanJard commented 2 years ago

Looks good - thank you for this! Are you happy for this to be included under the MIT license?

mvorisek commented 2 years ago

yes

AllanJard commented 2 years ago

Unfortunately I've had to mostly revert this change due to move_uploaded_file no longer work in a custom action due to this change, as reported here.

mvorisek commented 2 years ago

Hi @AllanJard, this PR fixes issue with open_basedir and as the file is moved with move_uploaded_file here, the user must use rename. I think we should mention this in upgrade docs instead, by reverting, the issue with open_basedir will pop up again.

AllanJard commented 2 years ago

With the next major change, yes I will consider this. copy also works it seems.