search

DataTables / FixedHeader

Fix the header, footer, left or right columns of a table in place, to always show them when scrolling
http://www.datatables.net/
Other
75 stars 83 forks source link

Added fixed corners for overlapping headers #20

Closed TheTesterQED closed 8 years ago

TheTesterQED commented 10 years ago

Hi Allan,

I've added support for fixing the corners when adjacent headers are enabled (eg. 2 right columns fixed along with top row). Currently, the header with the higher z-element will overlap the corner and scroll into it when the table is scrolled; my changes create a new fixed corner which will behave properly when scrolling in either direction.

I did notice that the change that introduced the ability to fix multiple left or right columns (bb5fd5d8582e530521f0671034f8ca8f6b05b74e) introduced some inconsistency when the border-collapse:collapse option is set - in my tests on Chrome/Firefox the right fixed column ends up with a double-border. I am unsure how to fix this at this moment, and even unsure about the status of border-collapse compatibility with DataTables; based on some older discussions I've seen on your forum I see that issues with border-collapse have been around, but I'm uncertain if they're fixed or not at this point. Let me know if at this point everything else plays nicely with border-collapse.

DataTables commented 10 years ago

Nice - thanks for this! It is a lot of extra code for that one little cell, but I'm not sure how we can get around that. If its okay with yourself, I'll review this in a little while properly - I'm up to my eyeballs with DataTables 1.10 :-)

Allan

njones11 commented 10 years ago

Hi, I just wanted to chime in and say that this bug is also affecting me. Consider this another vote for merging this in!

DataTables commented 8 years ago

This no longer works with v3, and since the columns can't be fixed any more this isn't actually a required feature. As such going to close.