search

DataTables / FixedHeader

Fix the header, footer, left or right columns of a table in place, to always show them when scrolling
http://www.datatables.net/
Other
75 stars 83 forks source link

Added headerOffset API to change headerOffset dynamically #72

Closed miljenko1 closed 9 years ago

miljenko1 commented 9 years ago

For the cases when headerOffset of an existing fixedHeader need to be changed, introduced headerOffset() API. Usage: table.fixedHeader.headerOffset( topOffset );

DataTables commented 9 years ago

Looks good - thanks! I wonder if you would be willing to make it a getter as well as a setter? Most of the API methods which can be used as setters can also be used as getters, so for consistency this would be a good change.

Also, are you happy for this to be released under the MIT license?

miljenko1 commented 9 years ago

Just added footerOffset to complete API changes started with headerOffset getter/setter

PS This is the first time I am using Git and still struggling to get it right,

DataTables commented 9 years ago

Was this intentionally closed?

miljenko1 commented 9 years ago

This is the first time I am using such kind of forum and contributing to an open source project and using Git(hub). So the answer is - no it is not intentionally closed. Q: did my 2nd and 3rd PR (headerOffset getter, footerOffset getter/setter) reached you?

DataTables commented 9 years ago

Yup - I see them. Thanks! I'll review them before the next FixedHeader release.

DataTables commented 9 years ago

Awesome. I've made a few little changes and added documentation, but your work will be in the next release. Thanks!