search

DataTables / FixedHeader

Fix the header, footer, left or right columns of a table in place, to always show them when scrolling
http://www.datatables.net/
Other
75 stars 83 forks source link

fnEqualiseHeights for Fixed Columns adds padding to height #9

Closed mvinoth closed 8 years ago

mvinoth commented 11 years ago

"fnEqualiseHeights" for calculating row heights while using "iLeft" adds padding to height from original cell. the height should be excluding top and bottom padding

DataTables commented 11 years ago

It seemed to depend upon the browser wether that was needed to not - at least that's my recollection. Can you link me to a test case showing the problem you are seeing (i.e. the misalignment that this is presumably causing?).

mvinoth commented 11 years ago

Allan, i took https://github.com/DataTables/FixedHeader/blob/master/zIndexes.html as test case. DataTables library is also from Dev channel. it happens on all browser. have tested in IE,FF,Chrome. all the same result.

Line 903: $(this).children().height( $(parent+' tr:eq('+k+')', original).outerHeight()); i feel it should be like this. $(this).children().height( $(parent+' tr:eq('+k+')', original).outerHeight() - iBoxHack);

another case i would like to mention here is when there is Border set to TD. I encountered this when I used keyTables along with this. KeyTables has Style with border 3px. this offset is also has some mismatch on left column freeze

DataTables commented 11 years ago

Yup - good point! Thanks for picking this up and letting me know about it. I'll look at fixing it for the next release.

DataTables commented 8 years ago

Wow - I never updated this bug - sorry! The rows are correctly displayed now - closing :-)