search

DataTables / Responsive

Responsive extension for DataTables, providing support for complex tables on all device screen sizes
Other
148 stars 86 forks source link

Missing js file in "Dist-DataTables-Responsive-Bootstrap#1.0.7" #51

Closed larvanitis closed 8 years ago

larvanitis commented 8 years ago

Probably your build scripts are based on your master branch, which includes the new style scripts.

1.0.7 should only include the css in bower.json etc.

DataTables commented 8 years ago

Hi - yes - this is in error.

The Dist- packages aren't quite ready yet - it is something that I'm actively working on, but I didn't see a way of building the bower packages without making them public. Its taking a little bit of time to build them up.

I don't actually expect that tagged versions of the packages to currently work - they will need the next tagged release which will happen next week.

larvanitis commented 8 years ago

Awesome!

dunnington commented 8 years ago

This appears to be a problem with the 2.0.0 release as well. The bower.json file lists js/responsive.bootstrap.js but the repo has no js folder. I noticed this forum post about requirejs from a few weeks ago, so I assume the build scripts are still being tweaked? FWIW, as long as the bower.json file properly lists all the necessary assets for a package in it's main configuration, including CSS and JS assets for a package is pretty easy (I use the grunt-bower and cssmin plugins in my builds), so trying to include both via requirejs is unnecessary.

DataTables commented 8 years ago

Yeah - I screwed that up - sorry. I had thought I'd fixed it since, but it looks not. I'll post back here when I really have fixed it.

DataTables commented 8 years ago

Its in now but not yet released.

Because of this packaging error the next release likely won't be far away.

dunnington commented 8 years ago

Fantastic, thanks for the quick response!

carmelowoodgett commented 8 years ago

Any new updates on this? I'm trying to decide if I should just go with a work-around or keep waiting on the update to the distribution.

DataTables commented 8 years ago

Not yet. Support has been taking about 99% of my time recently, so I've not had a chance to do any proper development.

carmelowoodgett commented 8 years ago

I hear ya. No worries. Thanks for the quick reply.

DataTables commented 8 years ago

Wrapping up for the next release. This is fixed and will be included in Responsive 2.0.1 which I expect to publish at the start of next week.