search

DataTables / TableTools

Please note that TableTools has now been retired and replaced by the Buttons and Select extensions which offers significant improvements and API integration with the rest of DataTables and the other extensions.
http://datatables.net/
Other
237 stars 149 forks source link

Fix for defered render deselect errors #51

Closed jglassmaker closed 10 years ago

jglassmaker commented 10 years ago

Changed fnSelectNone to match fnSelectAll which fixes defered render errors when using TableTools selection.

Errors were caused because fnGetSelected returns only TR nodes but when using defered render option we must use the aoData object.

DataTables commented 10 years ago

Thanks for these! The first fix looks great and I'd like to merge that in. The second one I'd wanted to fix with events to prevent a lot of unnecessary redrawing. I don't think(?) I can pull in just the first one using github. Can you possibly either remove the second or reissue with just the first?

jglassmaker commented 10 years ago

Thanks!

I actually didn't mean to include both commits ... and removing the one isn't working too well. Let me know if the revert commit will work - otherwise I can make a new pull request.

Shortly after I wrote the second commit regarding Fixed Columns plugin updating I had the same thought you did - a less overhead approach would be better. I can work on this if you don't have something in the works already.

DataTables commented 10 years ago

Yup looks like that should do it. Thanks for this!