search

DataTables / VisualEvent

Visually show Javascript events on a page
http://sprymedia.co.uk
1.04k stars 161 forks source link

Visual Event doesn't work on secure sites ( https ) #22

Closed jason-gu closed 11 years ago

jason-gu commented 11 years ago

Visual Event doesn't work on https sites. Probably caused by "http" being hard coded.

DataTables commented 11 years ago

sprymedia.co.uk doesn't currently do https as it is on a virtual host and doesn't have its own IP address.

I will be updating the site to use SNI in a little while (probably around a month with the way things are currently stacked up). https will work nicely then.

Having said that, yes there are a few little updates needed in the code to add https support, but they are trivial :-)

jason-gu commented 11 years ago

Looking forward to the updates and thanks for the quick reply.

DataTables commented 11 years ago

Fixed in e5854d15bd

jason-gu commented 11 years ago

Hi, I've used the bookmarklet on this page: http://sprymedia.co.uk/article/Visual+Event+2

However on any HTTPS pages, the loading fails, it simply says "Loading Visual Event" but nothing happens after a long wait.

Thank you for the great tool

DataTables commented 11 years ago

If you used Visual Event from before, then have you deleted and reinstalled the bookmarklet? You need to do so in order to able able to use it on https sites.

rakeshjuyal commented 11 years ago

New bookmarklet should be working with https . In fact, now it independent of protocol be it http or https.

DataTables commented 11 years ago

I really like the // method of making it protocol independent. Something I should uses more often!

rakeshjuyal commented 11 years ago

The first time I saw VisualEvent I too thought why this guy is not using // :)

idx3d commented 11 years ago

Visual Event from Chrome Webstore still not working for me with https protocol.

DataTables commented 11 years ago

You'll need to contact the author of the Chrome app wrapper that is in the web store. I'm afraid that's nothing to do with me :-)

idx3d commented 11 years ago

Okay, thanks. I'll try to contact him. ;)