search

DataTables / VisualEvent

Visually show Javascript events on a page
http://sprymedia.co.uk
1.04k stars 162 forks source link

Propose changes for file name + line number #48

Closed valtido closed 10 years ago

valtido commented 10 years ago

I feel it is more accepted to use filename.ext:123 as this can easily be copied and pasted and use when looking up a file on sublime, chrome dev tools source files.

it will help us save a few seconds each time we need to find the specific page and line number to make changes or place break points..

DataTables commented 10 years ago

Nice change - thanks for suggesting this. I'll rebuild and deploy Visual Event shortly.

valtido commented 10 years ago

A bit careless of me with the quotes, works like a charm, if I knew you'd respond this quickly would have suggested it monkeys ago :)

DataTables commented 10 years ago

No problem. You caught me at a good time for it :-)

valtido commented 10 years ago

ok, just thought you may want to have a look at this... https://developer.chrome.com/extensions/devtools_panels it might be a cool idea, to create a new panel "Visual Events" maybe this could be the way forward to resolve or alternative to https://github.com/DataTables/VisualEvent/issues/43 .

DataTables commented 10 years ago

Actually Chrome already has an event listeners list (also shown in the screenshot in the document you linked to). So I'm not sure how useful it would be. I suppose it would help tell what library assigned the code and where it was attached...

valtido commented 10 years ago

Function defined in Inline script:31

I think I may have made a mistake there, inline script:31 doesn't mean much... Thought you may want to have a look at it :)

DataTables commented 10 years ago

Yeah possibly not. I'll look at that when I get a chance.