DataTables / Vue

Vue plugin for DataTables
MIT License
64 stars 12 forks source link

feat!: script setup syntax #12

Closed sadeghbarati closed 1 year ago

sadeghbarati commented 1 year ago

// after tableRef.value.dt

AllanJard commented 1 year ago

Many thanks for this!

It looks like there is a lot of changes here, and I'm not sure I fully understand them all. For example the add script setup - I don't really get. Could you add a more detailed explanation for each commit please?

sadeghbarati commented 1 year ago

Sry for bad commit messages, I was in a hurry, I think you should merge or squash it instead of rebasing :face_in_clouds:

  1. Removed vue-cli and use vite instead for serving demo and building package
  2. Rename dev to playground and add some examples that you mentioned here https://datatables.net/blog/2022-06-22-vue
  3. Move to SFC + setup instead of SFC and defineComponent
  4. Use Volar to generate d.ts files and pack them into one with @microsoft/api-extractor
AllanJard commented 1 year ago

Awesome stuff - many thanks for this. Are you happy with it being included under the MIT license?

sadeghbarati commented 1 year ago

@AllanJard Ofcourse

If I missed something pls tell me to change