DataUSA / datausa-tracker

0 stars 0 forks source link

units_of_measurement modifications #239

Closed davelandry closed 2 years ago

davelandry commented 5 years ago

We're implementing some logic into the vizbuilder that is specific to each type of units_of_measurement, so in that vein we'd like to standardize some of the names we use (it's mostly changing a lot of measures to be just "People" instead of the specific type of people).

jspeis commented 5 years ago

@davelandry sounds good. Though regarding "Deaths", lets keep this as a distinct unit of measurement to preserve the red coloring of the measure like on the current Data USA

davelandry commented 5 years ago

@jspeis we don't color based on units_of_measurement, but on the name of the measure itself :-)

https://github.com/DataUSA/datausa-site/blob/canon/app/d3plus.js#L7-L59

jspeis commented 5 years ago

I see! Ok then we can rename those too

hwchen commented 5 years ago

Deaths as a unit of measurement only appears in chr.

hwchen commented 5 years ago

done in xenium