Backend fix to the issue where users can select a dir they don't have write permissions to when performing a retrieve.
Basically I've extended the checkFreeSpace method to also copy an empty file to the user space before doing anything else.
If it can't write it throws an error.
I did look at various ways of getting the permission from the sftp connection Google seemed to have varying opinions about whether that was either possible or reliable (mainly depending on platform)
All the tests pass on my machine which hopefully means that they pass on the build box too.
A couple of the test changes are to make size or speed params work on my local box we can revert those if folk like tbh I included those by mistake.
As usual we won't merge till things have been deployed / tested on demo but comments / feedback are fine :-)
Backend fix to the issue where users can select a dir they don't have write permissions to when performing a retrieve.
Basically I've extended the checkFreeSpace method to also copy an empty file to the user space before doing anything else.
If it can't write it throws an error.
I did look at various ways of getting the permission from the sftp connection Google seemed to have varying opinions about whether that was either possible or reliable (mainly depending on platform)
All the tests pass on my machine which hopefully means that they pass on the build box too.
A couple of the test changes are to make size or speed params work on my local box we can revert those if folk like tbh I included those by mistake.
As usual we won't merge till things have been deployed / tested on demo but comments / feedback are fine :-)