search

DataVault / datavault

DataVault Project
MIT License
20 stars 16 forks source link

upgrade docker image for MariaDB to mariadb:10.3.39 (for tests and local development) #825

Closed davidhay closed 1 month ago

dspeed2 commented 1 month ago

I've checked this on out my machine, pulled the new image and deployed without issue. I can see from Docker Desktop and the terminal that the new image is being used.

I've also ran all the tests on my machine without issue.

Once small thing which I suspect is related to me upgrading docker desktop rather than the changes is that I see

"WARN[0000] /Users/dspeed2/Documents/datavault/dv5/local-db/docker/docker-compose.yml: version is obsolete"

Whenever I run docker compose commands now. Personally I can live with that but if it is as simple as removing the version line from the config maybe we should do that?

I'm happy enough to commit either with or without the version line in the config.

davidhay commented 1 month ago

I also noticed the VERSION is no longer needed in docker compose files - just gets ignored with warning.