search

DataViva / dataviva-site

Rapid data visualization engine
MIT License
160 stars 45 forks source link

Rings "false" Node Title #33

Closed davelandry closed 10 years ago

davelandry commented 10 years ago

Sometimes in Rings, certain primary connection nodes have "false" for their title. See this example: http://dataviva.info/apps/builder/rings/rais/mg/m7110/all/isic/

davelandry commented 10 years ago

This will be fixed when the site is updated with the new version of D3plus.

mariohmol commented 10 years ago

When do u think that will be a good moment to do this upgrade? Considering that we will have a d3plus version that will not change enough to make big refactors...

davelandry commented 10 years ago

There have been a LOT of changes in D3plus since the release of DataViva. DataViva is currently using a customized pre-release version of D3plus. It is not going to be a small task to upgrade. I will probably be creating a separate branch to work on upgrading, and then merge in when we are ready.

Upgrading D3plus is not something that will happen within the next month or so.

mariohmol commented 10 years ago

All right.. i will search here another issue to put in place of that one (considering the milestone).. the same will happen to #64

davelandry commented 10 years ago

64 should still be fixed in the current milestone. We should keep using the DataViva translation method(s) for the time being.

davelandry commented 10 years ago

I have confirmed that this issue will be fixed automatically when we update D3plus.