DataWorkz-NL / KubeETL

ETL controller for Kubernetes
Apache License 2.0
4 stars 0 forks source link

Fix/unstructural open api schema #27

Closed Blokje5 closed 3 years ago

Blokje5 commented 3 years ago

Embedding of the Argo WorkflowSpec in #14 introduced problems generating valid CRDs. Initially, the main issue was the generation of unstructural schemas due to a conflict in keys (see https://github.com/kubernetes-sigs/controller-tools/issues/558 for details). However, there where a few other issues. Notably, Argo Workflows Full CRDs can also not be applied in a cluster. They "fix" the CRD by preserving every field of the request, which is what Kubernetes wanted to avoid with the structural OpenAPI schema. A seperate discussion should most likely be started on the Argo Workflows repo to get the full CRDs to a working state, but for now this fixes the issue on our end and allows us to continue.

Fixes #26

Signed-off-by: Lennard Eijsackers lennardeijsackers92@gmail.com