search

DataWorkz-NL / KubeETL

ETL controller for Kubernetes
Apache License 2.0
4 stars 0 forks source link

Feat/manager configuration #55

Closed Blokje5 closed 2 years ago

Blokje5 commented 2 years ago

Cleaning up the code around manager configuration and making it easier to add new components.

Also disabling webhooks by default as they require a tls cert to be available, which isn't the case most of the time locally.

Blokje5 commented 2 years ago

@ThijsKoot thanks for the review. I have considered writing tests, however I either just test configuring the manager (while valuable, it is a bit trivial), or they would be a real pain to write (e.g. check whether the manager registers the right watches with the API). Given that it is still early days, I decided to leave that for later.

ThijsKoot commented 2 years ago

Makes sense, LGTM then :D