search

DatabaseCleaner / database_cleaner-sequel

MIT License
17 stars 11 forks source link

Failure/Error: DatabaseCleaner[:sequel].strategy = :truncation #27

Closed ms-ati closed 2 years ago

ms-ati commented 2 years ago

This error appeared in 2.0.1

Failure/Error: DatabaseCleaner[:sequel].strategy = :truncation
    ArgumentError: wrong number of arguments (given 0, expected 1)
     # /usr/packages/ruby-2.7.2/gems/database_cleaner-sequel-2.0.1/lib/database_cleaner/sequel/truncation.rb:6:in `initialize'
     # /usr/packages/ruby-2.7.2/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaner.rb:85:in `new'
     # /usr/packages/ruby-2.7.2/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaner.rb:85:in `create_strategy'
     # /usr/packages/ruby-2.7.2/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaner.rb:45:in `strategy='
     # ./spec/rails_helper.rb:74:in `block (2 levels) in <top (required)>'
ms-ati commented 2 years ago

It appears that in 2.0.1 this was the breaking change: https://github.com/DatabaseCleaner/database_cleaner-sequel/commit/c70a12f54e7fa412d26ae783f9938bb358dd21de

ms-ati commented 2 years ago

It appears to be fixed in this commit: https://github.com/DatabaseCleaner/database_cleaner-sequel/commit/7ad713fb746005f624b4b791d2f3c100a2002cde

ms-ati commented 2 years ago

Are we planning a 2.0.2 release? Should 2.0.1 be marked as a regression so that folks stop upgrading to it?

etagwerker commented 2 years ago

Just released v2.0.2. Thanks! 👍