search

DatabaseCleaner / database_cleaner

Strategies for cleaning databases in Ruby. Can be used to ensure a clean state for testing.
https://www.rubydoc.info/github/DatabaseCleaner/database_cleaner
MIT License
2.94k stars 484 forks source link

Ruby 2.7 deprecations #665

Closed ngan closed 4 years ago

ngan commented 4 years ago

We're using Ruby 2.7 and are getting warnings from this gem:

database_cleaner-core-2.0.0.beta2/lib/database_cleaner/cleaners.rb:41: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
database_cleaner-core-2.0.0.beta2/lib/database_cleaner/cleaner.rb:28: warning: The called method `initialize' is defined here

I'd be more than happy to put up a PR...is there a minimum version of Ruby that this database_cleaner v2 plans to support?

etagwerker commented 4 years ago

@ngan That would be great. We are currently maintaining Ruby 2.5 and higher: https://github.com/DatabaseCleaner/database_cleaner/blob/master/.travis.yml

ngan commented 4 years ago

@etagwerker here ya go: https://github.com/DatabaseCleaner/database_cleaner/pull/667