search

DatabaseGroup / tree-similarity

Library for tree similarity algorithms and queries.
MIT License
74 stars 14 forks source link

Wrong test data #11

Closed marcus1337 closed 4 years ago

marcus1337 commented 4 years ago

In the test data file located here I noted that the last test contains invalid input. This would cause the test to always fail, which is probably something that you, the developers, do not want. The error can be easily found by opening up "CTRL+F" and searching "{{". "{{" is invalid syntax. The test is currently commented with, "# Bolzano - large trees (causing int overflow in strategy computation)".

mateuszpawlik commented 4 years ago

The input is valid. It represents an empty label. The details on the input format can be found in src/parser/bracket_notation_parser.h. I copy it here:

/// {LABEL{LABEL}{LABEL}}
///
/// where LABEL allows any character BUT the the structure brackets (by default
/// the curly brackets: {}) must be escaped as follows: \{ \}.
///
/// Example input with complex labels:
/// {a{\{[b],\{key:"value"\}\}{}}}
/// which is a path of three nodes with labels as follows:
///
///                         target LABEL (after removing escapes):
/// a                       -> a
/// |
/// \{[b],\{key:"value"\}\} -> {[b],{key:"value"}}
/// |
/// ""                      -> an empty label
marcus1337 commented 4 years ago

ah, ok.